Skip to content

[dynamicviz] cap alpha heuristic#17

Merged
marioernestovaldes merged 1 commit intodevfrom
codex/address-code-review-comments
Jun 18, 2025
Merged

[dynamicviz] cap alpha heuristic#17
marioernestovaldes merged 1 commit intodevfrom
codex/address-code-review-comments

Conversation

@marioernestovaldes
Copy link
Owner

@marioernestovaldes marioernestovaldes commented Jun 18, 2025

Summary

  • limit automatic alpha heuristic so opacity never exceeds 1

Testing

  • ruff check .
  • pytest -q

https://chatgpt.com/codex/tasks/task_e_6853295697d08333b6ac92fc5f54707d

Summary by Sourcery

Enhancements:

  • Limit the automatically computed alpha value to a maximum of 1.0.

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 18, 2025

Reviewer's Guide

This PR enhances the automatic alpha (opacity) heuristic in the stacked plotting function by capping the computed value at 1.0, preventing opacity values above 100% for small datasets.

Class diagram for updated alpha heuristic in stacked function

classDiagram
    class stacked {
        +stacked(df, label, alpha=None, ...)
        # alpha: float
    }
    note for stacked "alpha is now capped at 1.0 if computed value exceeds 1.0"
Loading

File-Level Changes

Change Details Files
Cap automatic alpha heuristic at 1.0
  • Add alpha = min(alpha, 1.0) to enforce the cap
  • Update the comment above the heuristic to reference the cap on opacity
dynamicviz/viz.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@marioernestovaldes marioernestovaldes merged commit 9d677cf into dev Jun 18, 2025
1 check passed
@marioernestovaldes marioernestovaldes deleted the codex/address-code-review-comments branch June 18, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant