"runtime checked" unchecked cast #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Mario,
great work! However I have an issue with the VisitorLambda example:
your main construct is to have a Map of Function<Object, A> and later cast functions of type Function<B,A> to Function<Object, A> (happens in Acceptor.then, it is just obscured by the fact that you use the raw type LambdaVisitor thus disabling the type system).
My Problem: this cast is unsound! If your Map<Class<?>, Function<Object, A>> ever escapes its scope (which it doesn't do, thus the example works) you are headed for ClassCastExceptions.
You also get a NPE if there is no Visitor registered for a specific class.
I came up with a different Implementation. You will see that there are still "unchecked" warnings, however the cast is checked at run time (which is arguably preferable).
Thanks! Christian