Skip to content

Improve ChainOfRespLambda #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve ChainOfRespLambda #4

wants to merge 1 commit into from

Conversation

@jbgi
Copy link

@jbgi jbgi commented Nov 9, 2016

I think #3 was not a good fix because we should:

  • not use soon-to-be-deprecated Optional#get (use flatMap instead, jdk9 will explicitly support this pattern)
  • assume all arguments are non-null: passing null arguments is insane and should not be covered for because it is a programming error.

@jbgi
Improve ChainOfRespLambda:
b2969e0 
 - Do not use soon-to-be-deprecated Optional#get (use flatMap instead)
 - Assume all arguments are non-null: insanity (passing null arguments) should not be covered for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jbgi