Skip to content

listenTo equivalents for Commands and Requests. #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jamesplease wants to merge 2 commits into
base: minor
Choose a base branch
from
Open

listenTo equivalents for Commands and Requests. #157

jamesplease wants to merge 2 commits into from

Conversation

@jamesplease
Copy link
Member

@jamesplease jamesplease commented Oct 26, 2014

WIP

Resolves #117

  • Add stopListening equivalents
  • Abstract logic to remove duplication
  • Tests
  • Docs

@jamesplease jamesplease force-pushed the listen-to-equivalent branch 2 times, most recently from fc6175d to f9a096a Compare October 26, 2014 04:24
@coveralls
Copy link

coveralls commented Oct 26, 2014

Coverage Status

Coverage decreased (-10.81%) when pulling f9a096a on listen-to-equivalent into 1ceb392 on minor.

@megawac
Copy link
Member

megawac commented Oct 26, 2014

Seems like a lot of duplicate code in here

@jamesplease
Copy link
Member Author

jamesplease commented Oct 26, 2014

Yeah. I'll abstract it more after I've added tests to verify that the behavior is what I want.

@coveralls
Copy link

coveralls commented Oct 27, 2014

Coverage Status

Coverage remained the same when pulling 84b9172 on listen-to-equivalent into ccb3468 on minor.

@jamesplease
Copy link
Member Author

jamesplease commented Oct 30, 2014

Note to future self: this is possibly blocked by #162.

@jamesplease jamesplease force-pushed the minor branch 2 times, most recently from 8abe023 to d2707b0 Compare January 28, 2015 03:20
@jamesplease jamesplease force-pushed the minor branch 2 times, most recently from b08cb7f to 619686b Compare January 28, 2015 05:27
@paulfalgout paulfalgout mentioned this pull request Mar 20, 2015
Merged
@jamesplease jamesplease mentioned this pull request May 5, 2015
Open
@jamiebuilds jamiebuilds added this to the v0.10.0 milestone Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jamesplease jamesplease

Labels

enhancement

Projects

None yet

Milestone

v0.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jamesplease @coveralls @megawac @jamiebuilds