Skip to content

Support for custom named Dockerfiles#248

Closed
tonur wants to merge 1 commit intomariotoffia:masterfrom
tonur:ckp/custom-dockerfile-name
Closed

Support for custom named Dockerfiles#248
tonur wants to merge 1 commit intomariotoffia:masterfrom
tonur:ckp/custom-dockerfile-name

Conversation

@tonur
Copy link
Copy Markdown

@tonur tonur commented Mar 15, 2022

Possible fix for #246 based on my suggestion.

This fix exposes the ImageBuilderConfig field internally to make it possible to write a custom ImageBuilderConfig.File value.

Input is gladly received, I don't know if this is the correct way to achieve a solution for #246.

@mariotoffia mariotoffia added this to the 3.0.0-RELEASE milestone Mar 16, 2022
@mariotoffia
Copy link
Copy Markdown
Owner

Hi @tonur and thanks for the PR!!

Can you pass the dockerfile (or empty) in the

internal string PrepareBuild()
instead?

I.e. revert the ImageBuilder.cs into private readonly ImageBuilderConfig _config = new ImageBuilderConfig();

Ok?

Cheers,
Mario :)

@tonur
Copy link
Copy Markdown
Author

tonur commented Jun 17, 2022

Hey @mariotoffia, I'll try this when I get home, I haven't had that much time lately 😅

@tonur
Copy link
Copy Markdown
Author

tonur commented Aug 29, 2023

I have forgotten about this PR and this is too long ago to me being able to push these changes. If this is still an issue, I hope it can be done by someone else.

@tonur tonur closed this Aug 29, 2023
@tonur tonur deleted the ckp/custom-dockerfile-name branch August 29, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants