docs: add optional hardening example for downstream servers#771
docs: add optional hardening example for downstream servers#771aak204 wants to merge 2 commits intomark3labs:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdded a new README section "Optional CI hardening for downstream servers" that provides a manually-triggered GitHub Actions workflow snippet to run the MCP Trust Kit against an mcp-go server and emit SARIF output for code scanning. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
664-669: Pin third-party actions to immutable commit SHAs in this hardening example.For a hardening-focused snippet, Line 668 should use a full commit SHA instead of the mutable tag (
@v0.4.0) to prevent supply-chain drift. GitHub's official security guidance recommends full-length commit SHAs as the only immutable reference method for actions.Suggested fix
- - uses: aak204/MCP-Trust-Kit@v0.4.0 + - uses: aak204/MCP-Trust-Kit@<full_commit_sha>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 664 - 669, Replace the mutable action tag "aak204/MCP-Trust-Kit@v0.4.0" with an immutable full commit SHA; locate the workflow step using the "uses: aak204/MCP-Trust-Kit@v0.4.0" entry and update it to "uses: aak204/MCP-Trust-Kit@<full-commit-sha>" (obtain the full commit SHA from the action repository) so the action reference is pinned to a specific immutable commit.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@README.md`:
- Around line 664-669: Replace the mutable action tag
"aak204/MCP-Trust-Kit@v0.4.0" with an immutable full commit SHA; locate the
workflow step using the "uses: aak204/MCP-Trust-Kit@v0.4.0" entry and update it
to "uses: aak204/MCP-Trust-Kit@<full-commit-sha>" (obtain the full commit SHA
from the action repository) so the action reference is pinned to a specific
immutable commit.
Description
This docs-only PR adds a small optional CI hardening example for downstream MCP servers built with
mcp-go.Fixes #<issue_number> (if applicable)
Type of Change
Checklist
Additional Information
Summary by CodeRabbit