Get user full name from Apple Sign-In #624
Open
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erol
force-pushed
the
get-user-full-name-from-apple-sign-in
branch
from
691fffc to
3e2f11a
Compare
Erol
force-pushed
the
get-user-full-name-from-apple-sign-in
branch
from
3e2f11a to
a266313
Compare
Author
|
Just wanted to ask if there's a prerequisite to get the pending workflow approved? |
Collaborator
|
@Erol It had to be manually done. I think there might be some threshold for it to be automatically approved (not sure about github's rules on this as some repos don't have this). Regardless, I've approved them for being run (I'm unsure if you push again if it needs to be manually approved again though) |
Author
|
Thanks @techknowlogick! Saw that the tests passed now |
Author
|
Also wondering what's the next step to get this across @techknowlogick? Who may I ask to make a review? |
|
Can you share your example code for apple auth? I have to manually parse body and add to url for CompleteUserAuth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user full name should be available to us as form parameters from the request when we make the call to
sess.Authorize. This implements getting the user full name if it is available and should resolve #616