Skip to content

Allow arbitrary extensions (not just .html files) #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikhuang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow arbitrary extensions (not just .html files) #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ StaticSiteGeneratorWebpackPlugin.prototype.apply = function(compiler) {
renderPromises = self.outputPaths.map(function(outputPath) {
var outputFileName = outputPath.replace(/^(\/|\\)/, ''); // Remove leading slashes for webpack-dev-server

if (!/\.(html?)$/i.test(outputFileName)) {
// If there is no extension, then assume it's a folder and add an index.html file
// (for a path like `/directory.with.dots/` then use `/directory.with.dots/index.html` )
if (!/\.(\w+)$/i.test(outputFileName)) {
outputFileName = path.join(outputFileName, 'index.html');
}

Expand Down
5 changes: 5 additions & 0 deletions test/success-cases/custom-file-names/expected-output/foo.bar/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<html>
<body>
<h1>/foo.bar/index.html</h1>
</body>
</html>
5 changes: 5 additions & 0 deletions test/success-cases/custom-file-names/expected-output/foo/bar/custom_ext.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<html>
<body>
<h1>/foo/bar/custom_ext.liquid</h1>
</body>
</html>
4 changes: 3 additions & 1 deletion test/success-cases/custom-file-names/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ var template = ejs.compile(fs.readFileSync(__dirname + '/template.ejs', 'utf-8')
var paths = [
'/custom.html',
'/foo/custom.html',
'/foo/bar/custom.html'
'/foo/bar/custom.html',
'/foo/bar/custom_ext.liquid',
'/foo.bar/index.html',
];

module.exports = {
Expand Down