Skip to content

fix: correct fyers holdings mapping for investment value and avg price #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
preet225 wants to merge 4 commits into
base: main
Choose a base branch
from
+11 −3
Open

fix: correct fyers holdings mapping for investment value and avg price #1053

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bd3ef0
feat: Add Fyers order, trade, and position data mapping and transform…
preet225 Mar 5, 2026
194ea9b
Merge branch 'marketcalls:main' into main
preet225 Mar 5, 2026
5b88858
Merge branch 'marketcalls:main' into main
preet225 Mar 8, 2026
fe407f9
Merge branch 'marketcalls:main' into main
preet225 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions broker/fyers/mapping/order_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,16 +357,24 @@ def transform_holdings_data(holdings_data):
transformed_data = []
for holdings in holdings_data:
pnl = round(holdings.get("pl", 0.0), 2)
cost_price = holdings.get("costPrice", 0.0)
ltp = holdings.get("ltp", 0)

# Handle zero cost price to avoid division by zero
if cost_price and cost_price != 0:
pnlpercent = round((ltp - cost_price) / cost_price * 100, 2)
else:
pnlpercent = 0.0

transformed_position = {
"symbol": holdings.get("symbol", ""),
"exchange": holdings.get("exchange", ""),
"quantity": holdings.get("quantity", 0),
"product": holdings.get("holdingType", ""),
"average_price": round(float(cost_price), 2),
"ltp": round(float(ltp), 2),
"pnl": pnl,
"pnlpercent": (holdings.get("ltp", 0) - holdings.get("costPrice", 0.0))
/ holdings.get("costPrice", 0.0)
* 100,
"pnlpercent": pnlpercent,
}
transformed_data.append(transformed_position)
return transformed_data
Expand Down