Skip to content

We should not be storing the GitHub information in a file #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

We should not be storing the GitHub information in a file #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# JetBrains
.idea

# Other
lib-cov
*.seed
*.log
Expand All @@ -17,3 +21,4 @@ node_modules
key.txt

graph-data.json

4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ DOWNLOAD + RUN LOCALLY
4. Register an application on Github
(Authorization callback URL: http://localhost:3000/auth/github)

5. In lib/config.js replace config.gh_clientId and config.gh_secret with the app's id and secret
5. Export the environment variables `ISSUE_GRAPH_GITHUB_ID` and `ISSUE_GRAPH_GITHUB_SECRET` with the app's id and secret.

6. `$ node lib/server.js`
6. `$ npm start`

7. Point your browser to http://localhost:3000
6 changes: 3 additions & 3 deletions lib/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var config = {};

config.gh_clientId = "3767b3e501e7804d2f60";
config.gh_secret = process.env.SECRET;
config.gh_clientId = process.env.ISSUE_GRAPH_GITHUB_ID;
config.gh_secret = process.env.ISSUE_GRAPH_GITHUB_SECRET;

module.exports = config;
module.exports = config;
Loading