Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Nov 5, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 5, 2025 21:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new test case to verify correct handling of ORDER BY clauses when using SELECT statements in FROM and INNER JOIN clauses, specifically targeting the reproduction of issue MLE-25002.

Key Changes:

  • Added test method orderByWithFromAndInnerJoinsThatUseSelects() to validate aggregation with ordered results from nested SELECT statements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

);

JsonNode doc = readJsonDocument("/customer/1.json");

Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespace on the blank line.

Suggested change

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Copyright Validation Results
Total: 2 | Passed: 2 | Failed: 0 | Skipped: 0 | at: 2025-11-06 20:22:21 UTC | commit: a6b2c76

✅ Valid Files

  • flux-cli/src/main/java/com/marklogic/flux/impl/importdata/AggregationParams.java
  • flux-cli/src/test/java/com/marklogic/flux/impl/importdata/ImportJdbcWithAggregatesTest.java

✅ All files have valid copyright headers!

@rjrudin rjrudin force-pushed the feature/jdbc-order-by branch from 28c4ed2 to 0d9444a Compare November 5, 2025 21:45
@rjrudin rjrudin force-pushed the feature/jdbc-order-by branch from 6f3162a to a6b2c76 Compare November 6, 2025 20:22
@rjrudin rjrudin marked this pull request as draft November 6, 2025 20:30
@rjrudin rjrudin closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants