MLE-19374 Updated cosine and annTopK functions #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the vector functions to align with server changes as of 2025-06-06 by renaming cosineSimilarity to cosine and modifying annTopK to accept a map for options. Key changes include:
- Renaming cosineSimilarity to cosine in tests, implementation, and documentation.
- Updating annTopK’s API to accept a Map<String, Object> instead of a float tolerance.
- Adjusting related documentation comments and test validations.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| marklogic-client-api/src/test/java/com/marklogic/client/test/rows/VectorTest.java | Updated test cases for vector functions and annTopK API changes |
| marklogic-client-api/src/main/java/com/marklogic/client/impl/VecExprImpl.java | Renamed cosineSimilarity to cosine and updated error messages accordingly |
| marklogic-client-api/src/main/java/com/marklogic/client/impl/PlanBuilderSubImpl.java | Modified annTopK signature to accept a Map of options |
| marklogic-client-api/src/main/java/com/marklogic/client/expression/VecExpr.java | Updated documentation to reflect the new cosine function |
| marklogic-client-api/src/main/java/com/marklogic/client/expression/PlanBuilder.java | Updated annTopK documentation and method signature |
Based on changes to the server on 2025-06-06. `cosine-similarity` is now `cosine` and `annTopK` now accepts a map as its 5th argument.
rjrudin
force-pushed
the
feature/20906-vector-functions-fix
branch
from
aca93d7 to
e030819
Compare
rjrudin
changed the title
BillFarber
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on changes to the server on 2025-06-06.
cosine-similarityis nowcosineandannTopKnow accepts a map as its 5th argument.