PDP-518: Changing the workspace permissions #1783
Conversation
SameeraPriyathamTadikonda
requested review from
BillFarber,
anu3990,
rjrudin and
stevebio
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds calls to updateWorkspacePermissions() in multiple pipeline post blocks to ensure workspace permissions are updated before tearing down Docker containers.
- Inserts
updateWorkspacePermissions()beforetearDownDocker()in each pipeline stage’spostblock.
| } | ||
| post { | ||
| always { | ||
| updateWorkspacePermissions() |
There was a problem hiding this comment.
Repeated calls to updateWorkspacePermissions() across multiple pipeline post blocks introduce duplication. Consider extracting this into a shared function or leveraging a declarative pipeline global post section to DRY up the configuration.
| updateWorkspacePermissions() |
There was a problem hiding this comment.
This seems like good advice - tearDownDocker is called in 5 places, and in each place, updateWorkspacePermissions needs to be called as well.
There was a problem hiding this comment.
Yes, I'll be creating another shared library for docker cleanup as well. I've separated these two to use this function for non-docker environments as well.
There was a problem hiding this comment.
We run our stages in parallel on different nodes, global post stage will clean up only on the last node.
| } | ||
| post { | ||
| always { | ||
| updateWorkspacePermissions() |
There was a problem hiding this comment.
This seems like good advice - tearDownDocker is called in 5 places, and in each place, updateWorkspacePermissions needs to be called as well.
2 participants
So we can incorporate your pull request, please share the following:
java -version)