Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jul 8, 2025

No description provided.

Copilot AI review requested due to automatic review settings July 8, 2025 17:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the existing SSL test to reflect a change in MarkLogic 12’s behavior and adds a new version-specific test.

  • Refactored JUnit imports to explicit annotation imports.
  • Updated the noSslContext test’s assertion message to note ML 12 behavior.
  • Added noSslContextWithMarkLogic12 to expect an IO exception when connecting without SSL under ML 12.
Comments suppressed due to low confidence (1)

marklogic-client-api/src/test/java/com/marklogic/client/test/ssl/OneWaySSLTest.java:17

  • Assertion methods like assertThrows, assertEquals, and assertTrue are used without static imports. Please add import static org.junit.jupiter.api.Assertions.*; or qualify these calls with Assertions. to ensure the test compiles.
import org.junit.jupiter.api.Assertions;

@rjrudin rjrudin merged commit 6a9e64b into develop Jul 9, 2025
2 checks passed
@rjrudin rjrudin deleted the feature/17505-test-fix branch July 9, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants