Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jul 23, 2025

Missed this reference in another build.gradle file

Copilot AI review requested due to automatic review settings July 23, 2025 16:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a Black Duck dependency scanning issue by standardizing the Apache Commons Lang3 dependency across build.gradle files. The change ensures consistent dependency management by explicitly declaring commons-lang3 version 3.18.0 and excluding the transitive dependency from ml-app-deployer to avoid version conflicts.

  • Updates commons-lang3 from version 3.17.0 to 3.18.0 in functional tests
  • Adds explicit exclusion of commons-lang3 module from ml-app-deployer dependency
  • Changes ml-app-deployer configuration from implementation to testImplementation scope

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
marklogic-client-api/build.gradle Removes empty line in dependencies block
marklogic-client-api-functionaltests/build.gradle Updates commons-lang3 version, adds exclusion, and changes dependency scope


testImplementation 'org.apache.commons:commons-lang3:3.18.0'
// Allows talking to the Manage API.
testImplementation ("com.marklogic:ml-app-deployer:5.0.0") {
Copy link

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ml-app-deployer dependency was changed from 'implementation' to 'testImplementation' scope. This is a significant change that could affect runtime availability of this dependency. Verify that ml-app-deployer is only needed for testing and not for production code execution.

Suggested change
testImplementation ("com.marklogic:ml-app-deployer:5.0.0") {
implementation ("com.marklogic:ml-app-deployer:5.0.0") {

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll actually set all of these to testImplementation, as none of them should be implementation since there's no src/main/java code.

Missed this reference in another build.gradle file.

Did some cleanup while I was at it - copyright fixes and converted custom Gradle tasks to be declared correctly.
@rjrudin rjrudin force-pushed the feature/junit-fix branch from afbac35 to 351ea2b Compare July 23, 2025 16:26
@rjrudin rjrudin merged commit 9e933c7 into develop Jul 23, 2025
1 of 2 checks passed
@rjrudin rjrudin deleted the feature/junit-fix branch July 23, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants