MLE-12345 Updated data services example project #1804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Black Duck was complaining about a license issue in version 6.3.0 of ml-development-tools
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ml-development-tools example project to resolve a Black Duck license issue by upgrading from version 6.3.0 to 7.1.0. The changes modernize the Gradle build configuration and update dependency versions.
- Updates ml-development-tools and marklogic-client-api dependencies from 6.3.0 to 7.1.0
- Modernizes Gradle task syntax from deprecated
taskto currenttasks.register()pattern
|
|
||
| task testFullPath(type: com.marklogic.client.tools.gradle.EndpointProxiesGenTask) { | ||
| tasks.register("testFullPath", com.marklogic.client.tools.gradle.EndpointProxiesGenTask) { | ||
| serviceDeclarationFile = "/Users/rrudin/workspace/java-client-api/example-project/src/main/ml-modules/root/inventory/service.json" |
There was a problem hiding this comment.
The serviceDeclarationFile path contains a hardcoded absolute path to a user's home directory (/Users/rrudin/). This should use a relative path or a configurable property to ensure the example works across different development environments.
Suggested change
| serviceDeclarationFile = "/Users/rrudin/workspace/java-client-api/example-project/src/main/ml-modules/root/inventory/service.json" | |
| serviceDeclarationFile = "src/main/ml-modules/root/inventory/service.json" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Black Duck was complaining about a license issue in version 6.3.0 of ml-development-tools