Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 6, 2025

And added comments to explain what the existing app-level retry support is doing vs what this for-now-undocumented interceptor will be doing.

Copilot AI review requested due to automatic review settings October 6, 2025 14:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the RetryInterceptor class to RetryIOExceptionInterceptor to better reflect its specific purpose of retrying requests that fail due to connection issues rather than HTTP status codes. The PR also adds comprehensive documentation explaining the difference between this interceptor's retry mechanism and the existing application-level retry support.

  • Renamed RetryInterceptor to RetryIOExceptionInterceptor for clearer naming
  • Added detailed comments explaining the interceptor's purpose and limitations
  • Enhanced request body handling to prevent retries on one-shot bodies like streams

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Common.java Updated import and usage of renamed interceptor class
RetryIOExceptionInterceptor.java Renamed class, improved documentation, and added one-shot body handling
StreamingOutputImpl.java Added isOneShot() method to prevent retry of streaming bodies
OkHttpServices.java Added documentation for existing retry mechanism and enhanced ObjectRequestBody
ConnectedRESTQA.java Updated import and usage of renamed interceptor class

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Copyright Validation Results
Total: 7 | Passed: 7 | Failed: 0 | Skipped: 0 | at: 2025-10-06 17:57:10 UTC | commit: a589fe1

✅ Valid Files

  • marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/functionaltest/ConnectedRESTQA.java
  • marklogic-client-api/src/main/java/com/marklogic/client/impl/OkHttpServices.java
  • marklogic-client-api/src/main/java/com/marklogic/client/impl/StreamingOutputImpl.java
  • marklogic-client-api/src/main/java/com/marklogic/client/impl/okhttp/RetryIOExceptionInterceptor.java
  • marklogic-client-api/src/main/java/com/marklogic/client/impl/okhttp/RetryableRequestBody.java
  • marklogic-client-api/src/test/java/com/marklogic/client/test/Common.java
  • marklogic-client-api/src/test/java/com/marklogic/client/test/datamovement/RowBatcherTest.java

✅ All files have valid copyright headers!

@rjrudin rjrudin force-pushed the feature/retry-interceptor branch 2 times, most recently from a02140a to a0bfde2 Compare October 6, 2025 17:22
And added comments to explain what the existing app-level retry support is doing vs what this for-now-undocumented interceptor will be doing.
@rjrudin rjrudin force-pushed the feature/retry-interceptor branch from a0bfde2 to a589fe1 Compare October 6, 2025 17:56
@rjrudin rjrudin merged commit c9817ea into develop Oct 6, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/retry-interceptor branch October 6, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants