Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 6, 2025

No description provided.

@rjrudin rjrudin requested a review from anu3990 as a code owner October 6, 2025 15:54
Copilot AI review requested due to automatic review settings October 6, 2025 15:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes publishing issues for the dev tools plugin by resolving Gradle 9 compatibility problems with project dependencies.

  • Changed from project dependency to external dependency for marklogic-client-api
  • Moved import statement to comply with standard ordering
  • Removed redundant publication configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

// Gradle 9 does not like for a plugin to have a project dependency; trying to publish it results in a
// NoSuchMethodError pertaining to getProjectDependency. So treating this as a 3rd party dependency. This creates
// additional work during development, though we rarely modify the code in this plugin anymore.
implementation "com.marklogic:marklogic-client-api:${version}"
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ${version} for the marklogic-client-api dependency may cause version mismatches. Consider using a specific version string or a dedicated variable like ${marklogicClientApiVersion} to ensure the correct version is used, especially since this is now treated as a third-party dependency.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Copyright Validation Results
Total: 1 | Passed: 0 | Failed: 0 | Skipped: 1 | at: 2025-10-06 15:54:34 UTC | commit: 423fbb7

⏭️ Skipped (Excluded) Files

  • ml-development-tools/build.gradle

✅ All files have valid copyright headers!

@rjrudin rjrudin merged commit 881a550 into develop Oct 6, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/jenkins-fix branch October 6, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants