MLE-26460 Preventing maxDocToUriBatchRatio value of -1 #1876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR addresses a server-side bug where maxDocToUriBatchRatio returns -1 when the number of server threads is less than the number of forests, preventing a LinkedBlockingQueue construction error due to negative capacity.
- Added validation to default
maxDocToUriBatchRatioto 1 when the server returns a value ≤ 0 - Created a comprehensive test to verify the fix by simulating the condition where server threads are fewer than forests
- Added utility methods in test infrastructure to support server configuration changes during testing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| marklogic-client-api/src/main/java/com/marklogic/client/datamovement/impl/DataMovementServices.java | Added validation to prevent negative maxDocToUriBatchRatio values by defaulting to 1 |
| marklogic-client-api/src/test/java/com/marklogic/client/datamovement/FewerServerThreadsThanForestsTest.java | Added test that reproduces the bug scenario by reducing server threads below forest count |
| marklogic-client-api/src/test/java/com/marklogic/client/test/Common.java | Added newAdminManager() utility method to support server configuration changes in tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| queryBatcher.awaitCompletion(); | ||
| dmm.stopJob(queryBatcher); | ||
|
|
||
| assertEquals(4, uriCount.get(), "Verifies that the 4 tet documents were found, and more importantly, " + |
There was a problem hiding this comment.
Corrected spelling of 'tet' to 'test'.
Suggested change
| assertEquals(4, uriCount.get(), "Verifies that the 4 tet documents were found, and more importantly, " + | |
| assertEquals(4, uriCount.get(), "Verifies that the 4 test documents were found, and more importantly, " + |
BillFarber
previously approved these changes
Jan 5, 2026
rjrudin
force-pushed
the
feature/26460-bug-fix
branch
from
b863a60 to
3a27dff
Compare
BillFarber
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.