MLE-26427 Initial exclusion support for XML #1879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to tackle error handling and unhappy path stuff next. More refactoring to be done as well.
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR introduces XML exclusion support for the IncrementalWriteFilter, extending the existing JSON exclusion functionality. The implementation allows users to specify XPath expressions to exclude specific XML elements from hash calculations during incremental writes.
Key changes:
- Added
xmlExclusionsparameter throughout the IncrementalWriteFilter class hierarchy - Implemented XML exclusion logic using XPath expressions in ContentExclusionUtil
- Refactored test structure by extracting common test setup into AbstractIncrementalWriteTest
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| IncrementalWriteTest.java | Refactored to extend AbstractIncrementalWriteTest and removed JSON exclusion test |
| ApplyExclusionsToIncrementalWriteTest.java | New test class containing both JSON and XML exclusion tests |
| AbstractIncrementalWriteTest.java | New base class providing shared test setup and utilities |
| DOMHandle.java | Updated to use centralized XmlFactories for XPath processor creation |
| XmlFactories.java | Added factory methods for XPathFactory and TransformerFactory |
| IncrementalWriteOpticFilter.java | Updated constructor to accept xmlExclusions parameter |
| IncrementalWriteFilter.java | Added xmlExclusions support and XML processing logic |
| IncrementalWriteEvalFilter.java | Updated constructor to accept xmlExclusions parameter |
| ContentExclusionUtil.java | Implemented XML exclusion functionality with XPath support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * @return the modified XML content with specified elements removed | ||
| * @throws Exception if the XML content cannot be parsed or serialized | ||
| */ | ||
| static String applyXmlExclusions(String uri, String xmlContent, String... xpathExpressions) throws Exception { |
There was a problem hiding this comment.
Throwing generic Exception reduces clarity for API consumers. Consider creating a specific exception type or throwing more specific exceptions like XPathExpressionException or TransformerException to help callers handle errors appropriately.
BillFarber
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to tackle error handling and unhappy path stuff next. More refactoring to be done as well.