MLE-26460 Fixing test failures #1880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR addresses test failures on Jenkins by fixing a test data cleanup issue in the test setup code. The problem stems from documents in the /acme/ directory that were previously deleted by AbstractOpticUpdateTest but are now being created by other tests with the test-data collection.
Changes:
- Updated the JavaScript query used for deleting documents before test runs to include the
/acme/directory
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @Override | ||
| protected final String getJavascriptForDeletingDocumentsBeforeTestRuns() { | ||
| // The "/acme/" directory was previously deleted by AbstractOpticUpdateTest. It still needs to be deleted | ||
| // some tests end up copying URIs to that directory but retain the 'test-data' collection. |
There was a problem hiding this comment.
The comment should start with a capital letter. Change 'some tests' to 'Some tests' at the beginning of line 24.
Suggested change
| // some tests end up copying URIs to that directory but retain the 'test-data' collection. | |
| // Some tests end up copying URIs to that directory but retain the 'test-data' collection. |
rjrudin
force-pushed
the
feature/failing-tests
branch
from
6ea9b3b to
d474a2e
Compare
Some test failures on Jenkins due to a test plumbing issue.
rjrudin
force-pushed
the
feature/failing-tests
branch
from
d474a2e to
0848de1
Compare
BillFarber
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test failures on Jenkins due to a test plumbing issue.