Merge develop into master for the 1.10.0 release #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into develop
Also added a little publishing information to the CONTRIBUTING file.
Update the new snapshot version
Also removed some unnecessary dependencies. All automated tests pass and the manual smoke tests work properly as well.
Updated all dependencies.
Gracefully handle problems with older versions of Kafka.
Update the version number for the soon-to-be release.
rjrudin
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Before releasing, add a short blurb to https://marklogic.github.io/kafka-marklogic-connector/writing-data.html#dead-letter-queue-configuration to describe what version of Kafka is required for proper DLQ support. Should note that the 1.9.0 connector release works with Kafka < 3.8, and 1.10.0 works with Kafka > 3.8.
Mention the version issue with the DLQ.
BillFarber
had a problem deploying
to
github-pages
GitHub Actions
Failure
rjrudin
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.