MLE-23227 - Force v3.18 of commons-lang to fix CVE #203
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates a dependency to force the use of commons-lang version 3.18 to address a security vulnerability (CVE). However, the only visible change in the provided diff is a documentation update that corrects a database name reference in the CONTRIBUTING.md file.
- Updates documentation to reference the correct database name (
data-hub-FINALinstead ofkafka-test-content)
|
|
||
| You can then verify that data is being written to MarkLogic by using MarkLogic's qconsole application to inspect the | ||
| contents of the `kafka-test-content` database. | ||
| contents of the `data-hub-FINAL` database. |
There was a problem hiding this comment.
The PR title indicates this change is about forcing commons-lang v3.18 to fix a CVE, but the only visible change is a database name correction in documentation. This creates confusion about the actual purpose of the PR. Consider updating the PR title to reflect the documentation fix, or ensure the dependency changes are included in the diff.
There was a problem hiding this comment.
Is this because we switched the test-app to be a DHF test app? If so, there are a few more references to "kafka-test-content" in the codebase to change.
BillFarber
changed the title
|
|
||
| You can then verify that data is being written to MarkLogic by using MarkLogic's qconsole application to inspect the | ||
| contents of the `kafka-test-content` database. | ||
| contents of the `data-hub-FINAL` database. |
There was a problem hiding this comment.
Is this because we switched the test-app to be a DHF test app? If so, there are a few more references to "kafka-test-content" in the codebase to change.
Updates some old references to kafka-test-content.
BillFarber
force-pushed
the
task/bumpCommonsLang
branch
from
ef9420b to
327f545
Compare
3 participants
I ran the automated tests as well as the manual tests with the Docker containers running the Confluence environment.