MLE-23399 - Removed kafka-junit and related tests. #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the kafka-junit library and its associated integration tests due to incompatibility with the current Kafka version. The kafka-junit library is no longer maintained and cannot work with Kafka versions beyond 3.6.0, necessitating its removal until a suitable replacement testing framework is identified.
Key changes:
- Removed 4 integration test classes that depended on kafka-junit
- Cleaned up utility methods in the abstract test base class that were only used by the removed tests
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ReadRowsViaOpticDslKafkaTest.java | Removed entire integration test for reading rows via Optic DSL with embedded Kafka |
| WriteTransformDocumentTest.java | Removed entire integration test for document transformation with embedded Kafka |
| WriteFromKafkaTest.java | Removed entire integration test for basic Kafka-to-MarkLogic writing |
| SendWriteFailureRecordsToDlqKafkaTest.java | Removed entire integration test for dead letter queue functionality |
| AbstractIntegrationSinkTest.java | Removed retry utility methods that were only used by the kafka-junit tests |
BillFarber
changed the title
rjrudin
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the kafka-junit library is no longer maintained and is incompatible with the version of Kafka that we are on, we are removing the library.
We'll switch to something else in the future.