Skip to content

Conversation

@SameeraPriyathamTadikonda
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings August 27, 2025 00:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds copyright header validation to the GitHub Actions workflow by integrating a reusable workflow from marklogic/pr-workflows and configuring file exclusions for the copyright check.

  • Updates workflow name from "🏷️ JIRA ID Validator" to "PR Workflow"
  • Adds copyright validation job that uses external workflow for checking copyright headers
  • Creates configuration file to exclude build files, docs, and GitHub workflow files from copyright checks

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/pr-workflow.yaml Adds copyright validation job and updates workflow name
.copyrightconfig Defines copyright start year and file exclusions for validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

pr-title: ${{ github.event.pull_request.title }}
copyright-validation:
name: © Validate Copyright Headers
uses: marklogic/pr-workflows/.github/workflows/copyright-check.yml@main
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using @main for the workflow reference is not recommended for production. Consider pinning to a specific version or commit SHA to ensure reproducibility and avoid potential breaking changes from upstream updates.

Copilot uses AI. Check for mistakes.
# - Dotfiles already skipped automatically
# Enable by removing the leading '# ' from the next line and editing values.
# filesexcluded: third_party/*, docs/generated/*.md, assets/*.png, scripts/temp_*.py, vendor/lib.js
filesexcluded: .github/*, README.md, Jenkinsfile, gradle/*, docker-compose.yml, *.gradle, gradle.properties, gradlew, gradlew.bat No newline at end of file
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The exclusion list is quite extensive and on a single line, making it difficult to read and maintain. Consider breaking this into multiple lines or adding comments explaining why each pattern is excluded.

Suggested change
filesexcluded: .github/*, README.md, Jenkinsfile, gradle/*, docker-compose.yml, *.gradle, gradle.properties, gradlew, gradlew.bat
filesexcluded: \

Copilot uses AI. Check for mistakes.
@BillFarber BillFarber merged commit 1fc4f0e into marklogic:develop Oct 2, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants