MLE-24489 - Upgrade to Kafka 4.1.0 and Confluent Platform 8.0 #227
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project from Kafka 4.1.0 to Confluent Platform 8.0, representing a major platform upgrade that includes updated Docker images, new monitoring infrastructure, and enhanced telemetry capabilities.
Key changes:
- Updates all Confluent Platform Docker images from version 7.6.1 to 8.0.0
- Adds new monitoring services (Prometheus, Alertmanager) and Apache Flink integration
- Introduces comprehensive telemetry configuration for improved observability
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test-app/docker-compose.yml | Updates all service images to CP 8.0, adds monitoring stack (Prometheus/Alertmanager), Flink services, and extensive telemetry configuration |
| test-app/.env | Adds environment variables for MarkLogic image and logs volume configuration |
| docker/prometheus/config/alertmanager-generated.yml | New Alertmanager configuration file with basic routing setup |
| CONTRIBUTING.md | Updates documentation to reflect new service versions, container names, and adds MarkLogic preparation instructions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| CONNECT_LOG4J_LOGGERS: org.apache.zookeeper=ERROR,org.I0Itec.zkclient=ERROR,org.reflections=ERROR | ||
| CONNECT_LOG4J_LOGGERS: log4j.rootLogger=DEBUG,org.apache.zookeeper=ERROR,org.I0Itec.zkclient=ERROR,org.reflections=ERROR | ||
| volumes: | ||
| - ../docker/confluent-marklogic-components:/usr/share/confluent-marklogic-components |
There was a problem hiding this comment.
The volume path uses a relative parent directory reference '../docker/confluent-marklogic-components' which may cause issues if the compose file is run from different working directories. Consider using an absolute path or defining this path in the .env file for better maintainability.
| - ../docker/confluent-marklogic-components:/usr/share/confluent-marklogic-components | |
| - ${CONFLUENT_MARKLOGIC_COMPONENTS_PATH}:/usr/share/confluent-marklogic-components |
BillFarber
force-pushed
the
upgradeToKafka4
branch
2 times, most recently
from
a706406 to
4436172
Compare
BillFarber
changed the title
BillFarber
force-pushed
the
upgradeToKafka4
branch
2 times, most recently
from
07c1401 to
35303fd
Compare
BillFarber
force-pushed
the
upgradeToKafka4
branch
from
35303fd to
61d278c
Compare
|
|
||
| // Force DHF to use the latest version of ml-app-deployer, which minimizes security vulnerabilities | ||
| implementation "com.marklogic:ml-app-deployer:5.0.0" | ||
| implementation "com.marklogic:ml-gradle:6.0.1" |
There was a problem hiding this comment.
Update the comment above to reference ml-gradle
Force upgrade to Spring 6 New files for the new CP stack and updated .gitignore for those files.
BillFarber
force-pushed
the
upgradeToKafka4
branch
from
61d278c to
6fb5e4e
Compare
2 participants
Force upgrade to Spring 6
New files for the new CP stack and updated .gitignore for those files.