Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 14, 2025

Copilot confirms that Kafka is not as picky about the version of Jackson used by connectors.

Copilot AI review requested due to automatic review settings October 14, 2025 13:06
@rjrudin rjrudin requested a review from BillFarber as a code owner October 14, 2025 13:06
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Copyright Validation Results
Total: 3 | Passed: 0 | Failed: 0 | Skipped: 3 | at: 2025-10-14 13:10:47 UTC | commit: 58ae3a2

⏭️ Skipped (Excluded) Files

  • .copyrightconfig
  • NOTICE.txt
  • build.gradle

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates third-party dependency versions and related documentation files. The main purpose is to bump Jackson and other dependencies to newer versions while updating the NOTICE file to reflect these changes.

  • Updates dependency versions for marklogic-data-hub, ml-app-deployer/ml-gradle, and jackson-dataformat-csv
  • Modifies copyright configuration to exclude additional docker files
  • Updates NOTICE.txt to reflect the new dependency versions and licensing information

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
NOTICE.txt Updates third-party dependency versions and references in the licensing notice
.copyrightconfig Expands file exclusions to cover all docker directory contents

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +25 to +26
ml-gradle 6.1.0 (Apache-2.0)
https://repo1.maven.org/maven2/com/marklogic/ml-gradle/
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency name changed from 'ml-app-deployer' to 'ml-gradle' but the Maven repository URL still points to ml-app-deployer. This creates inconsistency between the dependency name and its repository location.

Copilot uses AI. Check for mistakes.
Copilot confirms that Kafka is not as picky about the version of Jackson used by connectors.
@rjrudin rjrudin merged commit 20f849e into develop Oct 14, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/bumps branch October 14, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants