MLE-24829 Fixing cloud auth #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables cloud authentication support for the Kafka connector by adding "CLOUD" as a valid security context type in the configuration validator.
- Added "CLOUD" to the list of valid security context types
- Added a new test to verify cloud authentication configuration is accepted
- Removed two unused test utility classes (MarkLogicSourceConnectorConfigBuilder and MarkLogicSinkConnectorConfigBuilder)
- Updated documentation to clarify cloud authentication configuration
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/marklogic/kafka/connect/MarkLogicConfig.java | Added "CLOUD" to the validator for CONNECTION_SECURITY_CONTEXT_TYPE |
| src/test/java/com/marklogic/kafka/connect/source/ReadRowsViaOpticDslTest.java | Added cloudAuth test to verify cloud security context type is accepted |
| src/test/java/com/marklogic/kafka/connect/source/MarkLogicSourceConnectorConfigBuilder.java | Deleted unused test utility class |
| src/test/java/com/marklogic/kafka/connect/sink/MarkLogicSinkConnectorConfigBuilder.java | Deleted unused test utility class |
| docs/configuring-the-connector.md | Updated documentation to include CLOUD in list of security context types and added explicit configuration examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
docs/configuring-the-connector.md
Outdated
| - `ml.connection.securityContextType=CLOUD` | ||
| - `ml.connection.basePath` = the base path in your Progress Data Cloud instance that points to the REST API server you | ||
| wish to connect to | ||
| - `ml.connection.cloudApiKey` = the API key for authenticating with your MarkLogic Cloud instance |
There was a problem hiding this comment.
The documentation still references 'MarkLogic Cloud' but line 65 was updated to 'Progress Data Cloud'. This should be updated to 'Progress Data Cloud' for consistency.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
rjrudin
force-pushed
the
feature/cloud-fix
branch
2 times, most recently
from
2cabbc8 to
43dcf4b
Compare
Kafka validator for securityContextType values needs to accept "cloud". Deleted a couple unused test classes too.
rjrudin
force-pushed
the
feature/cloud-fix
branch
from
43dcf4b to
47be8ce
Compare
BillFarber
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka validator for securityContextType values needs to accept "cloud".
Deleted a couple unused test classes too.