Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 22, 2025

No description provided.

@rjrudin rjrudin requested a review from BillFarber as a code owner October 22, 2025 16:02
Copilot AI review requested due to automatic review settings October 22, 2025 16:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes cloud authentication support for the 1.11.1 release by adding "CLOUD" as a valid security context type and updating related documentation. The changes ensure that the connector can properly authenticate with Progress Data Cloud.

  • Added "CLOUD" as a valid security context type option
  • Updated documentation to reflect Progress Data Cloud terminology and configuration
  • Added test coverage to verify cloud authentication configuration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/main/java/com/marklogic/kafka/connect/MarkLogicConfig.java Added "CLOUD" to the list of valid security context types and updated documentation references from "MarkLogic Cloud" to "Progress Data Cloud"
src/test/java/com/marklogic/kafka/connect/source/ReadRowsViaOpticDslTest.java Added test to verify cloud authentication configuration is accepted and updated imports to use wildcard notation
gradle.properties Updated version from 1.11.0 to 1.11-SNAPSHOT for development
docs/configuring-the-connector.md Updated documentation to include CLOUD as a security context type option and added explicit configuration examples for each authentication method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.*;
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using wildcard imports for static assertions reduces code readability. Consider keeping the explicit imports for assertEquals, assertNull, assertTrue, and assertThrows (newly used in the test) to make dependencies clear.

Suggested change
import static org.junit.jupiter.api.Assertions.*;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.assertThrows;

Copilot uses AI. Check for mistakes.
@Test
void cloudAuth() {
RuntimeException ex = assertThrows(RuntimeException.class, () -> startSourceTask(
MarkLogicSourceConfig.CONNECTION_SECURITY_CONTEXT_TYPE, "cloud",
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security context type is specified as lowercase 'cloud', but the documentation and validator define it as uppercase 'CLOUD'. While this may work if the validation is case-insensitive, using the canonical uppercase form would improve consistency with the documented configuration values.

Suggested change
MarkLogicSourceConfig.CONNECTION_SECURITY_CONTEXT_TYPE, "cloud",
MarkLogicSourceConfig.CONNECTION_SECURITY_CONTEXT_TYPE, "CLOUD",

Copilot uses AI. Check for mistakes.
@rjrudin rjrudin force-pushed the feature/cloud-fix-1.x branch from b4914ab to eadd061 Compare October 22, 2025 18:21
@rjrudin rjrudin force-pushed the feature/cloud-fix-1.x branch from eadd061 to c7fcfb0 Compare October 27, 2025 16:50
@rjrudin rjrudin merged commit b0568dc into develop-1.x Oct 27, 2025
1 check passed
@rjrudin rjrudin deleted the feature/cloud-fix-1.x branch October 27, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants