-
Notifications
You must be signed in to change notification settings - Fork 15
MLE-24829 Fixing cloud auth for 1.11.1 release #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes cloud authentication support for the 1.11.1 release by adding "CLOUD" as a valid security context type and updating related documentation. The changes ensure that the connector can properly authenticate with Progress Data Cloud.
- Added "CLOUD" as a valid security context type option
- Updated documentation to reflect Progress Data Cloud terminology and configuration
- Added test coverage to verify cloud authentication configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/main/java/com/marklogic/kafka/connect/MarkLogicConfig.java |
Added "CLOUD" to the list of valid security context types and updated documentation references from "MarkLogic Cloud" to "Progress Data Cloud" |
src/test/java/com/marklogic/kafka/connect/source/ReadRowsViaOpticDslTest.java |
Added test to verify cloud authentication configuration is accepted and updated imports to use wildcard notation |
gradle.properties |
Updated version from 1.11.0 to 1.11-SNAPSHOT for development |
docs/configuring-the-connector.md |
Updated documentation to include CLOUD as a security context type option and added explicit configuration examples for each authentication method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertNull; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
| import static org.junit.jupiter.api.Assertions.*; |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using wildcard imports for static assertions reduces code readability. Consider keeping the explicit imports for assertEquals, assertNull, assertTrue, and assertThrows (newly used in the test) to make dependencies clear.
| import static org.junit.jupiter.api.Assertions.*; | |
| import static org.junit.jupiter.api.Assertions.assertEquals; | |
| import static org.junit.jupiter.api.Assertions.assertNull; | |
| import static org.junit.jupiter.api.Assertions.assertTrue; | |
| import static org.junit.jupiter.api.Assertions.assertThrows; |
| @Test | ||
| void cloudAuth() { | ||
| RuntimeException ex = assertThrows(RuntimeException.class, () -> startSourceTask( | ||
| MarkLogicSourceConfig.CONNECTION_SECURITY_CONTEXT_TYPE, "cloud", |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The security context type is specified as lowercase 'cloud', but the documentation and validator define it as uppercase 'CLOUD'. While this may work if the validation is case-insensitive, using the canonical uppercase form would improve consistency with the documented configuration values.
| MarkLogicSourceConfig.CONNECTION_SECURITY_CONTEXT_TYPE, "cloud", | |
| MarkLogicSourceConfig.CONNECTION_SECURITY_CONTEXT_TYPE, "CLOUD", |
b4914ab to
eadd061
Compare
eadd061 to
c7fcfb0
Compare
No description provided.