Feature/mle 24755 binary doc test fixes #1004
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or port 8017. Add a second error message for test using SSL to confirm error when connecting to non-SSL REST service. Message probably changed for ML12 (not sure, but error message in test does not work).
MLE-24312: fix ssl tests
…by default load of FIPS-forbidden MD5 digest algorithm. Incorporate the source from the abandoned www-authenticate project and fix in place.
MLE-24397 - fix issue on Linux FIPS reported by consultant/customer a…
…n another commit.. Delete and re-add existing www-authenticate files to www-authenticate-patched. Change path for require for requester and tests. Changes to www-authenticate will be in subsequent commit, for tracking
…eption on FIPS-enabled systems when the www-authenticate module is loaded via require. The MD5 digester functions are already created on demand when using DIGEST authentication. Use Buffer.from rather than deprecated new Buffer constructor form. Move the Parser_Authenticate_Info prototype statement to after the definition of the function. Add copyright to all the files.
MLE-24397 - fix reported issue on Linux FIPS around exception caused by default load of FIPS-forbidden MD5 digest algorithm. Incorporate the source from the abandoned www-authenticate project and fix in place.
…tements, unused variables, and move return note_error line outside of the for loop, which was probably intended.
MLE-123456 - polaris fixes: remove unreachable break and continue sta…
Also updated the Gradle wrapper and ml-gradle, and now requiring Java 17. This also will make it easier to convert the Jenkinsfile to use Docker as well, instead of rpm's.
Also bumped up tar-fs to resolve a vulnerability. Going to format Jenkinsfile in a subsequent PR.
No functional changes, though did add some labels to scripts for better traceability.
Also moved docker-compose to the root folder for consistency with other repos.
And formatted Jenkinsfile with it. It's our standard editorconfig with some Copilot recommendations added for a Node project.
The copyright checker expects "(c)" and will otherwise fail every file in a PR.
Jenkins is getting an issue resolving 4.7.0 ml-gradle, so shifting to 6.0.1 - which is fine to use here because we don't need ml-gradle for deploying any LSQT stuff.
…and only once. Set reasonable timeouts for some of the bulk operations and remove infinite timeouts which can hang the test.
…ations. Change annTopK tests to use await/rejects idiom which is easier to understand. Skip the cloud test that tries to connect to support.beta.marklogic.cloud. That DNS name is not resolving as of today.
…orTests MLE-24722 - make sure the done() method called within each test once …
When I saved this file in VS Code, I think the .editorconfig kicked in and made significant whitespace modifications. So making this commit first so I can then make real changes to this file and have them be easily understood.
- Removed deepcopy, using native Node structuredClone. - Moved eslint to devDependencies (which removes 50+ dependencies total from the real dependency graph!). - Upgraded busboy and documented why we're using it instead of dicer (going to use CONTRIBUTING for providing any explanations for things in package.json). - Removing usage of caret in package.json to avoid accidentally picking up malicious upgrades.
- Bumped json-text-sequence to latest version (1.0.1 to 4.0.2) - Bumped qs from 6.11 to 6.14 - Removed carets to request explicit versions And had Copilot clean up the "overrides" section. Most of these look like they originate from devDependencies - though a lot of them may have been from eslint, which was mistakenly party of dependencies. Will see what Black Duck thinks, but npm is reporting zero vulnerabilities.
Will try to trim this as devDependencies are updated.
No linting fixes yet. Changing from the older jshint to the modern eslint. The eslint config doesn't enforce whitespace yet, will do that in a later PR.
Fixed test that was do an equals comparison on the error message, and it no longer times out now.
This makes debugging much easier.
…criptions MLE-24733 - Adding more information to some test descriptions.
Zillion little changes, but any issues should cause test failures locally and on Jenkins.
Only using bunyan in logging.js, and that test seems very safe to run, so it's no longer excluded by Jenkinsfile. Removed the two "test-complete" logging tests that weren't actually doing anything. Removing winston allows for the "color" and "color-string" overrides to be removed as well as nothing else depends on them.
Using .npmrc instead of custom script to cause an error on `npm install`.
This was supporting a use case that doesn't exist - having the custom deployer read in the admin username/password. And the custom deployer is in the process of being smoked. One less dependency!
…romise objects to make test logic comprehension easier. Remove the incorrect assertion that on the first and subsequent call to onBatchSuccess that the number of transformed documents is always greater than or equal to the batch size. This is not always the case, sometimes on the first callback the number of transformed docs in the summary is less than the batch size.
…a-movement-fixes MLE-24755 - fix intermittent errors (hopefully): change to use modern…
stevebio
requested review from
BillFarber,
anu3990 and
rjrudin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.