MLE-24733 - revert test-complete-app #1009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the working version of the mlDeploy stuff to test-complete-app-mlDeploy
BillFarber
requested review from
anu3990,
rjrudin and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes made to the test-complete-app directory and moves the mlDeploy-related functionality to a new test-complete-app-mlDeploy directory, effectively separating deployment concerns from the base test application.
Key changes:
- Reverted
test-complete-appto its original state by removing deployment properties and Gradle tasks - Created new
test-complete-app-mlDeploydirectory with full deployment configuration including SSL setup - Fixed database client naming in optic test file from
dbSchemasClienttodbModClient
Reviewed Changes
Copilot reviewed 11 out of 70 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test-complete/nodejs-optic-generate-views.js | Updated database client variable name and database reference from Schemas to Modules |
| test-complete-app/gradle.properties | Removed mlDeploy-specific properties (modules database, schemas database, REST port) |
| test-complete-app/build.gradle | Removed curl tasks for people and companies data loading |
| test-complete-app-mlDeploy/* | Added new directory with complete mlDeploy configuration including REST API server setup, SSL certificate templates, and Gradle wrapper |
| .copyrightconfig | Added test-complete-app-mlDeploy to files excluded from copyright checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| var dbSchemasClient = marklogic.createDatabaseClient({ | ||
| database: 'Schemas', | ||
| var dbModClient = marklogic.createDatabaseClient({ | ||
| database: dbName + 'Modules', |
There was a problem hiding this comment.
String concatenation of dbName + 'Modules' is missing a separator. This will result in database names like 'nodeOpticFunctionalTestModules' without the expected hyphen or separator if dbName is something like 'nodeOpticFunctionalTest'. Verify that dbName includes the trailing separator, or add one explicitly: dbName + '-Modules'.
Suggested change
| database: dbName + 'Modules', | |
| database: dbName + '-Modules', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the working version of the mlDeploy stuff to test-complete-app-mlDeploy