MLE-24733 Deleting what should be unused etc/ files #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no references to these, so deleting these should be fine.
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete test setup and teardown scripts that are no longer needed, as the project has migrated to using ml-gradle for test infrastructure management. The changes clean up deprecated Node.js-based test scripts while retaining only the linting functionality in package.json.
Key changes:
- Removed npm test scripts from package.json (test, test:setup, test:teardown)
- Deleted multiple test setup and teardown JavaScript files from the etc/ directory
- Removed outdated TODO comments from test-setup-prompt.js
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed test-related npm scripts, keeping only doc and lint scripts |
| etc/users-setup.js | Deleted user setup script (entire file removed) |
| etc/test-teardown.js | Deleted main test teardown script (entire file removed) |
| etc/test-teardown-qa.js | Deleted QA environment teardown script (entire file removed) |
| etc/test-teardown-nodeOpticFunctionalTest.js | Deleted Optic functional test teardown script (entire file removed) |
| etc/test-teardown-dmsdk-qa.js | Deleted DMSDK QA teardown script (entire file removed) |
| etc/test-setup.js | Deleted main test setup script with database configuration (entire file removed) |
| etc/test-setup-qa.js | Deleted QA environment setup script (entire file removed) |
| etc/test-setup-prompt.js | Removed outdated TODO comments about ml-gradle migration |
| etc/test-setup-dmsdk-qa.js | Deleted DMSDK QA setup script (entire file removed) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rjrudin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no references to these, so deleting these should be fine.