MLE-26340 expose vec.precision and vec.trunc in Node client. #1048
+157
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update high vulnerability Add comment about VecVector Update copyright
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR exposes two new vector functions (vec.precision and vec.trunc) in the Node.js client library and updates copyright years from 2025 to 2026. The changes include adding the new function definitions to the generated plan builder, updating test cases to be more precise and comprehensive, and fixing a bug in the VecVector type handling.
- Added
vec.precisionandvec.truncfunction definitions with proper JSDoc documentation - Enhanced vector function test coverage with clearer assertions and better test data
- Fixed VecVector argument handling in
castArgto return the object instead of its arguments - Updated copyright notices across all affected files to 2026
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lib/plan-builder-generated.js | Added vec.precision and vec.trunc function definitions with JSDoc comments and parameter validation |
| lib/plan-builder-base.js | Fixed VecVector handling to return the object itself rather than arg._args; added explanatory comment |
| test-basic/optic-vector.js | Rewrote vector function tests with more precise assertions, better test data, and clearer comments |
| test-basic/plan-builder-generated.js | Updated vec.base64Decode test to use proper base64-encoded vector string with explanatory comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rjrudin
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update high vulnerability
Add comment about VecVector
Update copyright