Skip to content

Conversation

@anu3990
Copy link
Contributor

@anu3990 anu3990 commented Jun 27, 2025

No description provided.

Copilot AI review requested due to automatic review settings June 27, 2025 21:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates generated files with a new license header, adjusts existing plan-builder tests to align with changed vectorScore behavior, and adds an additional vectorScore test and a new Node server type.

  • Updated license headers in generated JS files to Progress Software’s years.
  • Modified expected values in plan-builder-generated.js tests and introduced a fourth vectorScore test.
  • Added a new Node class in the server type definitions.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
test-basic/plan-builder-generated.js Bumped license, changed expected test assertions, and added a new vec.vectorScore#4 test without version guard.
lib/server-types-generated.js Bumped license and inserted a newly generated Node class.
Comments suppressed due to low confidence (1)

lib/server-types-generated.js:48

  • [nitpick] The class name Node is very generic and may collide with other common types (e.g., DOM Node). Consider using a more descriptive name to avoid ambiguity.
class Node extends ServerType {

done();
}).catch(done);
});
it('vec.vectorScore#4', function(done) {
Copy link

Copilot AI Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new test isn’t guarded by the server version check used in the previous vectorScore tests, so it will run on versions <12 and likely fail. Consider adding if (serverConfiguration.serverVersion < 12) { this.skip(); } inside the test.

Suggested change
it('vec.vectorScore#4', function(done) {
it('vec.vectorScore#4', function(done) {
if (serverConfiguration.serverVersion < 12) {
this.skip();
}

Copilot uses AI. Check for mistakes.
@anu3990 anu3990 marked this pull request as draft June 27, 2025 21:36
@anu3990 anu3990 marked this pull request as ready for review July 2, 2025 21:12
@anu3990 anu3990 closed this Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant