-
Notifications
You must be signed in to change notification settings - Fork 53
MLE-23505 : jsDoc for vector-util.js is missing #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,6 +5,21 @@ | |||||
| 'use strict'; | ||||||
| const { Buffer } = require('buffer'); | ||||||
|
|
||||||
| /** | ||||||
| * Provides functions to encode and decode vectors. | ||||||
| * MarkLogic 12 or higher needed. | ||||||
| * @namespace vectorUtil | ||||||
| */ | ||||||
|
|
||||||
| /** | ||||||
| * Converts an array of vector float values into an encoded string. | ||||||
| * Encoding vectors before writing them to documents in MarkLogic 12 | ||||||
| * helps reduce the amount of disk space and memory consumed by vectors. | ||||||
| * @method vectorUtil#base64Encode | ||||||
| * @since 3.7.0 | ||||||
| * @param {float[]} vector - an array of float values | ||||||
| * @returns {string} an encoded string value. | ||||||
| */ | ||||||
| const base64Encode = (vector) => { | ||||||
| const dimensions = vector.length; | ||||||
| const buffer = Buffer.alloc(8 + 4 * dimensions); | ||||||
|
|
@@ -19,6 +34,13 @@ const base64Encode = (vector) => { | |||||
| return buffer.toString('base64'); | ||||||
| }; | ||||||
|
|
||||||
| /** | ||||||
| * Converts an encoded string value to an array of vectors. | ||||||
| * @method vectorUtil#base64Decode | ||||||
| * @since 3.7.0 | ||||||
| * @param {string} encodedVector - an encoded string value. | ||||||
| * @returns {float[]} an array of float values. | ||||||
|
||||||
| * @returns {float[]} an array of float values. | |
| * @returns {number[]} an array of float values. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type annotation 'float[]' is not valid JSDoc syntax. Use 'number[]' instead, as JavaScript uses the number type for all numeric values including floats.