Skip to content

MLE-24312: fix ssl tests #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

MLE-24312: fix ssl tests #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test-app/docker-compose-nightlies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ services:
volumes:
- ./containerLogs:/var/opt/MarkLogic/Logs
ports:
- 8000-8016:8000-8016
- 8000-8017:8000-8017
- 8024-8029:8024-8029
- 8079:8079
2 changes: 1 addition & 1 deletion test-app/docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ services:
- ./docker/marklogic/logs:/var/opt/MarkLogic/Logs
ports:
- 8000-8002:8000-8002
- 8015-8016:8015-8016
- 8015-8017:8015-8017
3 changes: 2 additions & 1 deletion test-basic/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@ describe('database clients', function () {
.result()
.catch(error => {
try{
assert(error.message.toString().includes('You have attempted to access an HTTP server using HTTPS. Please check your configuration.'));
assert(error.message.toString().includes('You have attempted to access an HTTP server using HTTPS. Please check your configuration.') ||
error.message.toString().includes('write EPROTO'));
Comment on lines +149 to +150
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message checking logic is duplicated with error.message.toString() called twice. Consider storing the result in a variable to improve readability and avoid redundant computation.

Suggested change
assert(error.message.toString().includes('You have attempted to access an HTTP server using HTTPS. Please check your configuration.') ||
error.message.toString().includes('write EPROTO'));
const errorMsg = error.message.toString();
assert(errorMsg.includes('You have attempted to access an HTTP server using HTTPS. Please check your configuration.') ||
errorMsg.includes('write EPROTO'));

Copilot uses AI. Check for mistakes.
done();
} catch(err){
done(err);
Expand Down