MLE-24397 - fix reported issue on Linux FIPS around exception caused by default load of FIPS-forbidden MD5 digest algorithm. Incorporate the source from the abandoned www-authenticate project and fix in place. #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n another commit.. Delete and re-add existing www-authenticate files to www-authenticate-patched. Change path for require for requester and tests. Changes to www-authenticate will be in subsequent commit, for tracking
stevebio
requested review from
BillFarber,
anu3990 and
rjrudin
as code owners
There was a problem hiding this comment.
Pull Request Overview
Fixes a FIPS compliance issue on Linux where the default loading of MD5 digest algorithm caused exceptions. The solution incorporates and patches source code from the abandoned www-authenticate project to prevent MD5 from being loaded by default.
- Relocates www-authenticate module to a patched version that avoids MD5 loading issues
- Updates require paths throughout the codebase to use the patched module
- Removes documentation comments that may no longer be relevant
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-basic/digestauth-fips-nomd5load.js | Updates test to use patched www-authenticate module path |
| lib/www-authenticate-patched/www-authenticate.js | Removes JSDoc documentation and whitespace from the patched module |
| lib/requester.js | Updates require path to use the patched www-authenticate module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…eption on FIPS-enabled systems when the www-authenticate module is loaded via require. The MD5 digester functions are already created on demand when using DIGEST authentication. Use Buffer.from rather than deprecated new Buffer constructor form. Move the Parser_Authenticate_Info prototype statement to after the definition of the function. Add copyright to all the files.
stevebio
force-pushed
the
task/fipsMD5Fix2
branch
from
ab11629 to
9d57aef
Compare
rjrudin
approved these changes
Sep 22, 2025
anu3990
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLE-24397 - fix reported issue on Linux FIPS around exception caused by default load of FIPS-forbidden MD5 digest algorithm. Incorporate the source from the abandoned www-authenticate project and fix in place.