Skip to content

Conversation

@stevebio
Copy link
Collaborator

…tements, unused variables, and move return note_error line outside of the for loop, which was probably intended.

…tements, unused variables, and move return note_error line outside of the for loop, which was probably intended.
Copilot AI review requested due to automatic review settings September 22, 2025 20:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses static analysis issues identified by Polaris by cleaning up unreachable code and unused variables in the www-authenticate authentication library. The changes focus on improving code quality by removing dead code patterns.

  • Removed unused variable declarations (q, x, last_tok)
  • Eliminated unreachable break and continue statements
  • Fixed placement of error return statement to execute after loop completion

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/www-authenticate-patched/www-authenticate.js Removed unused variables and moved error return outside loop, eliminated unreachable break
lib/www-authenticate-patched/parsers.js Removed unused variable and unreachable continue statement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@stevebio stevebio merged commit d39fb6f into marklogic:develop Sep 22, 2025
1 of 2 checks passed
@stevebio stevebio deleted the task/polarisFixes branch September 22, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants