MLE-24511 Bumping server to latest 12 nightly #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test application infrastructure to use the latest nightly MarkLogic server version and modernizes the build toolchain. The changes include upgrading Java from version 8 to 17, updating Gradle wrapper and ml-gradle plugin versions, and configuring Docker Compose to use environment variables for MarkLogic image selection.
- Upgraded Java requirement from 8.x to 17.x across documentation and CI pipeline
- Updated Gradle wrapper from 8.4 to 8.14.3 and ml-gradle plugin from 5.0.0 to 6.0.1
- Modernized Docker Compose configuration with environment variable support for MarkLogic image selection
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test-app/gradlew.bat | Updated Gradle wrapper batch script with newer version and improved error handling |
| test-app/gradlew | Updated Gradle wrapper shell script with enhanced POSIX compliance and argument parsing |
| test-app/gradle/wrapper/gradle-wrapper.properties | Upgraded Gradle distribution from 8.4 to 8.14.3 with additional validation settings |
| test-app/docker-compose.yaml | Replaced hardcoded MarkLogic image with environment variable references |
| test-app/build.gradle | Updated ml-gradle plugin from version 5.0.0 to 6.0.1 |
| test-app/.env | Added environment file defining MarkLogic image and logs volume variables |
| Jenkinsfile | Updated Java home directory from OpenJDK 1.8 to JDK 17 |
| CONTRIBUTING.md | Updated documentation to reflect Java 17.x requirement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rjrudin
force-pushed
the
feature/server-bump
branch
from
7c70820 to
86c34c8
Compare
rjrudin
force-pushed
the
feature/server-bump
branch
3 times, most recently
from
cefcfce to
6c54cb9
Compare
rjrudin
changed the title
Also updated the Gradle wrapper and ml-gradle, and now requiring Java 17. This also will make it easier to convert the Jenkinsfile to use Docker as well, instead of rpm's.
rjrudin
force-pushed
the
feature/server-bump
branch
from
6c54cb9 to
9cdd739
Compare
rjrudin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the Gradle wrapper and ml-gradle, and now requiring Java 17. This also will make it easier to convert the Jenkinsfile to use Docker as well, instead of rpm's.