-
Notifications
You must be signed in to change notification settings - Fork 53
MLE-24685 Skipping timestamp test that fails due to server issue #984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
ed1510b to
f0c895e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses server bugs by skipping a problematic timestamp test and re-enabling a previously skipped JSON constructor test, while also adding documentation about the complete test suite.
- Skips "TEST 38 - with old timestamp" due to server bug MLE-24724
- Re-enables "TEST 1 - construct json from literals" test that was previously skipped
- Updates CONTRIBUTING.md with information about the test-complete folder
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-complete/nodejs-optic-nodes.js | Re-enables previously skipped JSON constructor test |
| test-complete/nodejs-optic-from-views.js | Skips timestamp test due to server bug MLE-24724 |
| CONTRIBUTING.md | Adds documentation about test-complete folder setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }); | ||
|
|
||
| it('TEST 38 - with old timestamp', function (done) { | ||
| // Skipping due to server bug MLE-24724 |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment references bug MLE-24724, but the PR title mentions MLE-24685. Consider verifying the correct bug number or adding both if they are related.
| // Skipping due to server bug MLE-24724 | |
| // Skipping due to server bug MLE-24724 (see also MLE-24685) |
stevebio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done finding this one!
No description provided.