Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 13, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Copyright Validation Results
Total: 3 | Passed: 2 | Failed: 0 | Skipped: 1 | at: 2025-10-14 00:25:12 UTC | commit: f0c895e

⏭️ Skipped (Excluded) Files

  • CONTRIBUTING.md

✅ Valid Files

  • test-complete/nodejs-optic-from-views.js
  • test-complete/nodejs-optic-nodes.js

✅ All files have valid copyright headers!

@rjrudin rjrudin force-pushed the feature/delete-some-tests branch from ed1510b to f0c895e Compare October 14, 2025 00:24
@rjrudin rjrudin changed the title MLE-24685 Debugging tests MLE-24685 Skipping timestamp test that fails due to server issue Oct 14, 2025
@rjrudin rjrudin marked this pull request as ready for review October 14, 2025 00:25
Copilot AI review requested due to automatic review settings October 14, 2025 00:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses server bugs by skipping a problematic timestamp test and re-enabling a previously skipped JSON constructor test, while also adding documentation about the complete test suite.

  • Skips "TEST 38 - with old timestamp" due to server bug MLE-24724
  • Re-enables "TEST 1 - construct json from literals" test that was previously skipped
  • Updates CONTRIBUTING.md with information about the test-complete folder

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
test-complete/nodejs-optic-nodes.js Re-enables previously skipped JSON constructor test
test-complete/nodejs-optic-from-views.js Skips timestamp test due to server bug MLE-24724
CONTRIBUTING.md Adds documentation about test-complete folder setup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

});

it('TEST 38 - with old timestamp', function (done) {
// Skipping due to server bug MLE-24724
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment references bug MLE-24724, but the PR title mentions MLE-24685. Consider verifying the correct bug number or adding both if they are related.

Suggested change
// Skipping due to server bug MLE-24724
// Skipping due to server bug MLE-24724 (see also MLE-24685)

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@stevebio stevebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done finding this one!

@rjrudin rjrudin merged commit 3805c2f into develop Oct 14, 2025
7 checks passed
@rjrudin rjrudin deleted the feature/delete-some-tests branch October 14, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants