Skip to content

MLE-24763 Including server response body in error message #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

MLE-24763 Including server response body in error message #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/responder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,6 +1039,9 @@ function isResponseStatusOkay(response) {
((typeof contentType === 'string' || contentType instanceof String) &&
/^application\/([^+]+\+)?json(\s*;.*)?$/.test(contentType)) ?
mlutil.parseJSON(bodyMsg) : bodyMsg;

// Enhance error message with response body details for better debugging
clientError.message = `${clientError.message}; server response: ${bodyMsg}`;
}
operation.errorListener(clientError);
}));
Expand Down
37 changes: 20 additions & 17 deletions test-basic/validateDoc-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,24 +184,27 @@ describe('optic-update validateDoc tests', function () {
});

it('test validateDoc with 1 invalid doc and no "onError" defined, should return nothing in 11.1-, or throw an exception on 11.2+', function (done) {
try {
const plan = op.fromDocDescriptors([{ uri: '/test/optic/validateDoc/toValidate1.xml' }])
.joinDocCols(null, op.col('uri'))
.validateDoc('doc', { kind: 'xmlSchema' });
db.rows.query(plan, options).then(res => {
try {
(res === undefined).should.equal(true);
done();
} catch (e) {
done(e);
}
}).catch(e => {
e.message.should.equal('query rows: response with invalid 500 status with path: /v1/rows/update');
const plan = op.fromDocDescriptors([{ uri: '/test/optic/validateDoc/toValidate1.xml' }])
.joinDocCols(null, op.col('uri'))
.validateDoc('doc', { kind: 'xmlSchema' });

db.rows.query(plan, options).then(res => {
// If we get here, the query succeeded (expected in 11.1-)
try {
(res === undefined).should.equal(true);
done();
});
} catch (e) {
done(e);
}
} catch (e) {
done(e);
}
}).catch(e => {
// If we get here, the query failed (expected in 11.2+)
try {
e.message.should.containEql('query rows: response with invalid 500 status with path: /v1/rows/update');
done();
} catch (assertionError) {
done(assertionError);
}
});
});

// Skip this test until the 'onError' function is available in plan-builder.js
Expand Down