Skip to content

MLE-24763 Lint: Preferring const #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

MLE-24763 Lint: Preferring const #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ module.exports = [
"no-unused-vars": "error",
"no-undef": "error",

// ES6+ modernization - GO TIME! 🚀
"prefer-const": "error", // Use const for variables never reassigned
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding prefer-const as an error will cause lint failures because this PR leaves numerous let declarations that are never reassigned (e.g., server-exec.js line 247 source is not reassigned). Either convert such let usages to const in this PR or temporarily set prefer-const to 'warn' to avoid blocking builds.

Suggested change
"prefer-const": "error", // Use const for variables never reassigned
"prefer-const": "warn", // Use const for variables never reassigned (temporarily set to warn to avoid blocking builds)

Copilot uses AI. Check for mistakes.
"no-var": "error", // Disallow var, use let/const instead

// Spacing rules (disabled for initial setup - TODO: Fix in separate PR)
"arrow-spacing": "off",
"space-before-blocks": "off",
Expand Down
Loading