Skip to content

Increase max label limit from 10 to 15#45

Draft
markmur wants to merge 1 commit intomainfrom
ae-task-93-max-number-of-labels
Draft

Increase max label limit from 10 to 15#45
markmur wants to merge 1 commit intomainfrom
ae-task-93-max-number-of-labels

Conversation

@markmur
Copy link
Copy Markdown
Owner

@markmur markmur commented Apr 2, 2026

Summary

Increases the maximum number of labels a user can create from 10 to 15, giving users more room to organize their tasks.

Approach

  • Extracted the magic number into a named MAX_LABELS constant exported from Labels.tsx
  • Made the limit prop optional with MAX_LABELS as the default value, removing the need to pass it explicitly in Todo.tsx
  • Added a guard in handleSave to enforce the limit even if the UI button check is bypassed (e.g. via browser console)
  • Added component tests for the label limit boundary conditions using Vitest + Testing Library
  • Set up the Vitest test infrastructure (happy-dom environment, test-setup file)

Co-authored-by: Claude noreply@anthropic.com
Orchestrated-by: ae noreply@shopify.com

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 2, 2026

Deploy Preview for what-todo-web ready!

Name Link
🔨 Latest commit 6c87f35
🔍 Latest deploy log https://app.netlify.com/projects/what-todo-web/deploys/69ce2aa149ad42000996cf42
😎 Deploy Preview https://deploy-preview-45--what-todo-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

The label limit controls how many labels a user can create before the
'Create new label' button is hidden. Bump from 10 to 15 to give users
more room for organizing their tasks.

Co-authored-by: Claude <noreply@anthropic.com>
Orchestrated-by: ae <noreply@shopify.com>
@markmur markmur force-pushed the ae-task-93-max-number-of-labels branch from 21126f1 to 6c87f35 Compare April 2, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant