Skip to content

fix: outDir delete regression#238

Merged
DylanPiercey merged 1 commit intomainfrom
fix-delete-outdir
Dec 1, 2025
Merged

fix: outDir delete regression#238
DylanPiercey merged 1 commit intomainfrom
fix-delete-outdir

Conversation

@DylanPiercey
Copy link
Contributor

Fixes a regession from #236 which deleted the outDir by default before Marko Run could read some generated Marko files.

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

🦋 Changeset detected

Latest commit: 0923204

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

This patch release for @marko/vite removes conditional logic that controlled the build.emptyOutDir setting based on linked and SSR states. Previously, the code toggled emptyOutDir to false in linked scenarios and to true for SSR/browser entry separation. The removal of this logic resolves a regression where the default deletion of the output directory prevented Marko Run from locating generated files. The emptyOutDir behavior now defaults to standard configuration.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'fix: outDir delete regression' clearly and concisely summarizes the main change - fixing a regression related to output directory deletion.
Description check ✅ Passed The PR description directly relates to the changeset, explaining that it fixes a regression from PR #236 where outDir deletion prevented Marko Run from reading generated files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-delete-outdir

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3119464 and 0923204.

📒 Files selected for processing (2)
  • .changeset/mighty-wolves-laugh.md (1 hunks)
  • src/index.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • src/index.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test: node@24 (windows-latest)
  • GitHub Check: test: node@22 (windows-latest)
🔇 Additional comments (1)
.changeset/mighty-wolves-laugh.md (1)

1-5: Changeset entry looks good.

The patch version bump is appropriate for a regression fix, and the description clearly documents the issue being resolved.


Comment @coderabbitai help to get the list of available commands and usage tips.

@DylanPiercey DylanPiercey merged commit d710d5a into main Dec 1, 2025
9 checks passed
@DylanPiercey DylanPiercey deleted the fix-delete-outdir branch December 1, 2025 15:22
@github-actions github-actions bot mentioned this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant