Skip to content

Conversation

@LuLaValva
Copy link
Member

  • Add ?bundle to esm.sh links for better package support, the one I found that didn't work before was "p5"
  • Fix crazy vertical stretching bug for menu on safari
    image
  • Change tab logic so it selects latest tab, though really we should fix the root cause
  • Gradients in gecko disappear on ::selection, so I hard-coded color

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

Walkthrough

The pull request makes four targeted updates across styling and functionality. It adds WebKit text fill color styling for text selections, modifies the tab selection logic to use a different index value when adding files, introduces Safari-specific and screen-size-aware conditions for animation timeline features, and adds a bundle query parameter to CDN module resolution requests.

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Various bug fixes' is vague and generic, using non-descriptive terminology that doesn't convey specific information about which bugs are being fixed. Replace with a more specific title that highlights the primary bug fix, such as 'Fix Safari menu stretching and add bundle parameter to esm.sh links' or similar.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description is clearly related to the changeset, providing specific details about each of the four bug fixes implemented in the pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f3052d and 76dc3a6.

📒 Files selected for processing (4)
  • src/routes/+layout.style.scss
  • src/routes/playground/tags/playground/tags/editor/tags/tabs/tabs.marko
  • src/styles/sticky.scss
  • src/util/workspace/cdn-plugin.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/*.marko

📄 CodeRabbit inference engine (.cursorrules)

In Marko files, use JS-style comments (// comment or /* comment */) instead of HTML comments (<!-- comment -->)

Files:

  • src/routes/playground/tags/playground/tags/editor/tags/tabs/tabs.marko
🔇 Additional comments (4)
src/routes/playground/tags/playground/tags/editor/tags/tabs/tabs.marko (1)

92-93: LGTM!

The fix correctly selects the newly added tab. Since selected is assigned before the array is expanded, tabs.length (the current count N) becomes the index of the soon-to-be-added element at position N.

src/routes/+layout.style.scss (1)

73-80: LGTM!

Adding -webkit-text-fill-color to ::selection is a proper fix for ensuring text remains visible when selected, particularly for elements that use -webkit-text-fill-color: transparent with gradient backgrounds. Without this override, the selection can appear broken in certain browsers.

src/styles/sticky.scss (1)

25-38: LGTM!

The two-branch structure correctly addresses the Safari rendering bug:

  • Large screens exclude Safari via the -webkit-hyphens: none hack to avoid the scaleY issue
  • Small screens include Safari since the bug doesn't manifest there

The media query conditions are mutually exclusive, ensuring @content is applied exactly once per applicable browser/screen-size combination.

src/util/workspace/cdn-plugin.ts (1)

16-21: The ?bundle parameter is not a valid esm.sh query parameter.

According to esm.sh documentation, the parameter to bundle a module with all external dependencies is ?standalone (not ?bundle). The parameter ?bundle=false actually disables sub-module bundling. The code at lines 17-20 uses ?bundle without documentation support; verify whether this should be ?standalone instead, or if the parameter should be removed entirely if bundling is not the intended behavior.

Likely an incorrect or invalid review comment.


Comment @coderabbitai help to get the list of available commands and usage tips.

@LuLaValva LuLaValva merged commit 5718ddc into main Jan 13, 2026
2 checks passed
@LuLaValva LuLaValva deleted the various-bug-fixes branch January 13, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants