sendtables: remove Entity.BindPosition() and PropertyValue.Float64Val()

Author: markus-wa

pkg/demoinfocs/common/player.go

@@ -278,9 +278,9 @@ func (p *Player) Velocity() r3.Vector {
 	}
 
 	return r3.Vector{
-		X: p.Entity.PropertyValueMust("localdata.m_vecVelocity[0]").Float64Val(),
-		Y: p.Entity.PropertyValueMust("localdata.m_vecVelocity[1]").Float64Val(),
-		Z: p.Entity.PropertyValueMust("localdata.m_vecVelocity[2]").Float64Val(),
+		X: float64(p.Entity.PropertyValueMust("localdata.m_vecVelocity[0]").FloatVal),
+		Y: float64(p.Entity.PropertyValueMust("localdata.m_vecVelocity[1]").FloatVal),
+		Z: float64(p.Entity.PropertyValueMust("localdata.m_vecVelocity[2]").FloatVal),
 	}
 }
 

pkg/demoinfocs/sendtables/entity.go

@@ -271,16 +271,6 @@ func (e *entity) OnPositionUpdate(h func(pos r3.Vector)) {
 	}
 }
 
-// BindPosition binds the entity's position to a pointer variable.
-// The pointer is updated every time a position-relevant property is updated.
-//
-// See also OnPositionUpdate()
-func (e *entity) BindPosition(pos *r3.Vector) {
-	e.OnPositionUpdate(func(newPos r3.Vector) {
-		*pos = newPos
-	})
-}
-
 // Returns a coordinate from a cell + offset
 func coordFromCell(cell, cellWidth int, offset float64) float64 {
 	return float64(cell*cellWidth-maxCoordInt) + offset

pkg/demoinfocs/sendtables/entity_interface.go

@@ -44,11 +44,6 @@ type Entity interface {
 	//
 	// See also Position()
 	OnPositionUpdate(h func(pos r3.Vector))
-	// BindPosition binds the entity's position to a pointer variable.
-	// The pointer is updated every time a position-relevant property is updated.
-	//
-	// See also OnPositionUpdate()
-	BindPosition(pos *r3.Vector)
 	// OnDestroy registers a function to be called on the entity's destruction.
 	OnDestroy(delegate func())
 	// Destroy triggers all via OnDestroy() registered functions.

pkg/demoinfocs/sendtables/propdecoder.go

@@ -85,11 +85,6 @@ func (v PropertyValue) BoolVal() bool {
 	return v.IntVal > 0
 }
 
-// Float64Val returns FloatVal converted from float32 to float64.
-func (v PropertyValue) Float64Val() float64 {
-	return float64(v.FloatVal)
-}
-
 type propertyDecoder struct{}
 
 func (propertyDecoder) decodeProp(prop *property, reader *bit.BitReader) {