tests: make sure only known parser warnings occur in the test demo set (#285)

Author: markus-wa

pkg/demoinfocs/demoinfocs_test.go

@@ -361,9 +361,28 @@ func TestDemoSet(t *testing.T) {
 
 				p := demoinfocs.NewParser(f)
 
-				p.RegisterEventHandler(func(event events.GenericGameEvent) {
-					if event.Name == "bot_takeover" {
-						t.Log(event.Data)
+				p.RegisterEventHandler(func(warn events.ParserWarn) {
+					switch warn.Type {
+					case events.WarnTypeBombsiteUnknown:
+						if p.Header().MapName == "de_grind" {
+							t.Log("expected known issue with bomb sites on de_grind occurred:", warn.Message)
+
+							return
+						}
+
+					case events.WarnTypeTeamSwapPlayerNil:
+						t.Log("expected known issue with team swaps occurred", warn.Message)
+						return
+
+					case events.WarnTypeGameEventBeforeDescriptors:
+						if strings.Contains(name, "POV-orbit-skytten-vs-cloud9-gfinity15sm1-nuke.dem") {
+							t.Log("expected known issue for POV demos occurred:", warn.Message)
+
+							return
+						}
+
+					default:
+						t.Error("unexpected parser warning occurred:", warn.Message)
 					}
 				})
 

pkg/demoinfocs/events/events.go

@@ -503,8 +503,10 @@ type StringTableCreated struct {
 type WarnType int
 
 const (
-	WarnTypeUndefined       = iota
-	WarnTypeBombsiteUnknown // may occur on de_grind for bombsite B as the bounding box of the bombsite is wrong
+	WarnTypeUndefined                  = iota
+	WarnTypeBombsiteUnknown            // may occur on de_grind for bombsite B as the bounding box of the bombsite is wrong
+	WarnTypeTeamSwapPlayerNil          // TODO: figure out why this happens
+	WarnTypeGameEventBeforeDescriptors // may occur in POV demos
 )
 
 // ParserWarn signals that a non-fatal problem occurred during parsing.

pkg/demoinfocs/game_events.go

@@ -20,7 +20,10 @@ func (p *parser) handleGameEventList(gel *msg.CSVCMsg_GameEventList) {
 
 func (p *parser) handleGameEvent(ge *msg.CSVCMsg_GameEvent) {
 	if p.gameEventDescs == nil {
-		p.eventDispatcher.Dispatch(events.ParserWarn{Message: "received GameEvent but event descriptors are missing"})
+		p.eventDispatcher.Dispatch(events.ParserWarn{
+			Message: "received GameEvent but event descriptors are missing",
+			Type:    events.WarnTypeGameEventBeforeDescriptors,
+		})
 
 		return
 	}
@@ -571,6 +574,7 @@ func (geh gameEventHandler) playerTeam(data map[string]*msg.CSVCMsg_GameEventKey
 		// TODO: figure out why this happens and whether it's a bug or not
 		geh.dispatch(events.ParserWarn{
 			Message: "Player team swap game-event occurred but player is nil",
+			Type:    events.WarnTypeTeamSwapPlayerNil,
 		})
 	}
 }