Skip to content

fix: use helm upgrade instead of helm install #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markusobsil merged 1 commit into from
Apr 18, 2025
Merged

fix: use helm upgrade instead of helm install #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,30 +19,31 @@ clean:

deploy-controlplane:
@scripts/print_header.sh "Deploy istio control plane"
@helm install istio-base --repo $(ISTIO_HELM_REPO) base --create-namespace --namespace $(ISTIO_CP_NS) \
@helm upgrade --install istio-base --repo $(ISTIO_HELM_REPO) base --create-namespace --namespace $(ISTIO_CP_NS) \
--version $(ISTIO_VERSION) --values helm/istio-global-values.yaml
@helm install istiod --repo $(ISTIO_HELM_REPO) istiod --namespace $(ISTIO_CP_NS) --version $(ISTIO_VERSION) \
--values helm/istiod-values.yaml --values helm/istio-global-values.yaml
@helm upgrade --install istiod --repo $(ISTIO_HELM_REPO) istiod --namespace $(ISTIO_CP_NS) \
--version $(ISTIO_VERSION) --values helm/istiod-values.yaml --values helm/istio-global-values.yaml
@scripts/print_header.sh "Add Istio global configuration"
@kubectl apply --namespace $(ISTIO_CP_NS) -f manifests/istio/telemetry.yaml
@kubectl apply --namespace $(ISTIO_CP_NS) -f manifests/istio/peerauthentication.yaml

deploy-ambient: check-istiod
@scripts/print_header.sh "Deploy istio CNI"
@helm install istio-cni --repo $(ISTIO_HELM_REPO) cni --namespace $(ISTIO_CP_NS) --version $(ISTIO_VERSION) \
--values helm/istio-cni-values.yaml --values helm/istio-global-values.yaml
@helm upgrade --install istio-cni --repo $(ISTIO_HELM_REPO) cni --namespace $(ISTIO_CP_NS) \
--version $(ISTIO_VERSION) --values helm/istio-cni-values.yaml --values helm/istio-global-values.yaml
@scripts/print_header.sh "Deploy ztunnel"
@helm install ztunnel --repo $(ISTIO_HELM_REPO) ztunnel --namespace $(ISTIO_CP_NS) --version $(ISTIO_VERSION) \
--values helm/ztunnel-values.yaml --values helm/istio-global-values.yaml
@helm upgrade --install ztunnel --repo $(ISTIO_HELM_REPO) ztunnel --namespace $(ISTIO_CP_NS) \
--version $(ISTIO_VERSION) --values helm/ztunnel-values.yaml --values helm/istio-global-values.yaml

check-istiod:
@scripts/print_header.sh "Checking status of istiod pods"
@scripts/check_pod.sh $(ISTIO_CP_NS) app=istiod

deploy-ingress: check-istiod
@scripts/print_header.sh "Deploy istio ingress gateway"
@helm install istio-ingress --repo $(ISTIO_HELM_REPO) gateway --create-namespace --namespace $(ISTIO_INGRESS_NS) \
--version $(ISTIO_VERSION) --values helm/istio-ingress-values.yaml --values helm/istio-global-values.yaml
@helm upgrade --install istio-ingress --repo $(ISTIO_HELM_REPO) gateway --create-namespace \
--namespace $(ISTIO_INGRESS_NS) --version $(ISTIO_VERSION) --values helm/istio-ingress-values.yaml \
--values helm/istio-global-values.yaml
@scripts/print_header.sh "Checking status of istio-ingress pods"
@scripts/check_pod.sh $(ISTIO_INGRESS_NS) app=istio-ingress
@openssl req -x509 -nodes -days 7 -newkey rsa:2048 -keyout web.key -out web.crt -subj \
Expand All @@ -54,8 +55,8 @@ deploy-ingress: check-istiod

deploy-egress:
@scripts/print_header.sh "Deploy istio egress gateway"
@helm install istio-egress --repo $(ISTIO_HELM_REPO) gateway --create-namespace --namespace $(ISTIO_EGRESS_NS) \
--version $(ISTIO_VERSION) --values helm/istio-global-values.yaml
@helm upgrade --install istio-egress --repo $(ISTIO_HELM_REPO) gateway --create-namespace \
--namespace $(ISTIO_EGRESS_NS) --version $(ISTIO_VERSION) --values helm/istio-global-values.yaml
@scripts/print_header.sh "Checking status of istio-egress pods"
@scripts/check_pod.sh $(ISTIO_EGRESS_NS) app=istio-egress

Expand Down