Skip to content

Potential fix for code scanning alert no. 53: Incorrect conversion between integer types #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marle3003 merged 2 commits into from
Dec 14, 2025
Merged

Potential fix for code scanning alert no. 53: Incorrect conversion between integer types #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42dc604
Potential fix for code scanning alert no. 53: Incorrect conversion be…
marle3003 Dec 14, 2025
5bee462
add test
marle3003 Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions schema/avro/schema/parser_json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ func parseType(v interface{}, s *Schema, typeName string) (interface{}, error) {
if math.Trunc(val) != val {
return 0, Errorf("type", "invalid type, expected %v but got %v", typeName, ToType(v))
}
// Ensure the value fits in a 32-bit signed integer
if val < math.MinInt32 || val > math.MaxInt32 {
return 0, Errorf("type", "integer value %v out of bounds for Avro int32", val)
}
return int(val), nil
}
case "long":
Expand Down
13 changes: 12 additions & 1 deletion schema/avro/schema/parser_json_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ package schema_test

import (
"encoding/json"
"github.com/stretchr/testify/require"
"fmt"
"math"
"mokapi/config/dynamic"
"mokapi/config/dynamic/dynamictest"
"mokapi/schema/avro/schema"
"testing"

"github.com/stretchr/testify/require"
)

func TestParser_Parse_Json(t *testing.T) {
Expand Down Expand Up @@ -50,6 +53,14 @@ func TestParser_Parse_Json(t *testing.T) {
require.EqualError(t, err, "invalid type, expected int but got float\nschema path #/type")
},
},
{
name: "not int32",
input: fmt.Sprintf("%v", int64(math.MaxInt32)+1),
schema: &schema.Schema{Type: []interface{}{"int"}},
test: func(t *testing.T, v interface{}, err error) {
require.EqualError(t, err, "integer value 2.147483648e+09 out of bounds for Avro int32\nschema path #/type")
},
},
{
name: "long",
input: `123`,
Expand Down
Loading