Fix useLogin should invalidate the getPermissions cache
#10392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Consider an Admin that has some pages that allow anonymous access, and also a
authProvider.getPermissions()implementation, that, say, returns'user'when the user is logged in, andundefinedwhen the user is not logged in.If the user first accesses the anonymous parts of the Admin, the cached permission will be
undefined. But if he then logs in, without leaving the Admin, then the cache is not updated, and the permissions still returnundefinedinstead of'user'.Solution
Invalidate the
getPermissionscache after a successful login, to force a refetch of the permissions.How To Test
https://react-admin-storybook-31pnpeyju-marmelab.vercel.app/?path=/story/ra-core-auth-uselogin--permissions-state
Additional Checks
masterfor a bugfix, ornextfor a featureAlso, please make sure to read the contributing guidelines.